Skip to content

Update Next.js Build Options with content from Manual Setup page #12852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

inventarSarah
Copy link
Collaborator

DESCRIBE YOUR PR

Update Next.js Build Options with content from the Manual Setup page:

  • added unstable_sentryWebpackPluginOptions
  • added more content to tunnelRoute
  • added excludeServerRoutes

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 4:47pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 4:47pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 4:47pm

Copy link

codecov bot commented Feb 26, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.46MB -0.0%
../instrumentation.js -3 bytes 791.26kB -0.0%
9523.js -3 bytes 767.46kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/nosTfau99BOulH6WfXhY0/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/nosTfau99BOulH6WfXhY0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/J_OINySnd5glYDwoAmS2D/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/J_OINySnd5glYDwoAmS2D/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Comment on lines 153 to 154
Pass configuration options directly to the Sentry Webpack Plugin
[`@sentry/webpack-plugin`](https://www.npmjs.com/package/@sentry/webpack-plugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pass configuration options directly to the Sentry Webpack Plugin
[`@sentry/webpack-plugin`](https://www.npmjs.com/package/@sentry/webpack-plugin)
Pass configuration options directly to the [Sentry Webpack Plugin](https://www.npmjs.com/package/@sentry/webpack-plugin)

@@ -146,6 +146,21 @@ If set to `true`, the Sentry SDK will attempt to tree-shake code related to trac

## Next.js Specific Options

<SdkOption
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe move this out of Next.js specific options so it is at the same level but on the end of the page!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to the end of the section as discussed 👍

@chargome
Copy link
Member

@inventarSarah I re-triggered the 404-lint action, if it still fails this time please just try to rebase on master 🙏

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chargome chargome merged commit b61cf6a into master Feb 28, 2025
11 checks passed
@chargome chargome deleted the smi/nextjs/manual-setup-move-content-options branch February 28, 2025 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants