-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Small improvements to traces_sampler
configuration.
#13470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
traces_sampler
configuration.
Bundle ReportChanges will increase total bundle size by 237 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
sfanahata
reviewed
Apr 23, 2025
platform-includes/performance/traces-sampler-as-sampler/python.mdx
Outdated
Show resolved
Hide resolved
sfanahata
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The include renders properly. I made a nit suggestion for a change.
Co-authored-by: Shannon Anahata <[email protected]>
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR A small change to make the documentation for `traces_sampler` a bit better. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: Shannon Anahata <[email protected]>
codyde
added a commit
that referenced
this pull request
Apr 26, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (49 commits) Bump API schema to f203c35d (#13523) Update index.mdx (#13345) feat(toggle): Adding docs for the toggle command (#13487) feat(Unity): Added `trace ID` connecting error explainer (#13516) feat(Unity): Editor Facelift (#13514) feat(Unity): Updated `options` and error capture explainer (#12904) Add data collected page for KMP (#13485) adjust language to be clear on developer privacy responsability (#13502) Factory and Teamcamp integrations (#13365) feat: More clearly document log envelope item in logs spec (#13501) Small improvements to `traces_sampler` configuration. (#13470) docs(js): Further clarify `denyUrls` (#13481) fix(js): Update `denyUrls` text in filtering page (#13494) docs(js): Fix uglify example command (#13329) chore(legal): Add note about how users are identified on Mobile (#13465) feat(native): add data collected page (#13483) ref(sourcemaps): Add faulty community-maintained packages to troubleshooting doc (#12915) feat(changelog): Add missing form-textarea class to editor (#12893) Remove 'Set Up' prefix from sidebar titles across all platforms (#13392) Bump API schema to 7028abc0 (#13490) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
A small change to make the documentation for
traces_sampler
a bit better.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES