Skip to content

Small improvements to traces_sampler configuration. #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2025

Conversation

antonpirker
Copy link
Member

DESCRIBE YOUR PR

A small change to make the documentation for traces_sampler a bit better.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 10:47am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 10:47am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 10:47am

@antonpirker antonpirker changed the title Antonpirker/python traces sampler Small improvements to traces_sampler configuration. Apr 22, 2025
@antonpirker antonpirker marked this pull request as ready for review April 22, 2025 11:38
Copy link

codecov bot commented Apr 22, 2025

Bundle Report

Changes will increase total bundle size by 237 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB 243 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/EbqO2M6qttZ8oViqg_uGN/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/EbqO2M6qttZ8oViqg_uGN/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/vKvghiMny1JEDIMb9eCO4/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/vKvghiMny1JEDIMb9eCO4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 84 bytes 388.51kB 0.02%
../app/platform-redirect/page.js.nft.json 84 bytes 388.43kB 0.02%
../app/sitemap.xml/route.js.nft.json 84 bytes 386.4kB 0.02%

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The include renders properly. I made a nit suggestion for a change.

@antonpirker antonpirker enabled auto-merge (squash) April 24, 2025 10:32
@antonpirker antonpirker merged commit be86902 into master Apr 24, 2025
15 checks passed
@antonpirker antonpirker deleted the antonpirker/python-traces-sampler branch April 24, 2025 10:47
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
A small change to make the documentation for `traces_sampler` a bit
better.

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)

---------

Co-authored-by: Shannon Anahata <[email protected]>
codyde added a commit that referenced this pull request Apr 26, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (49 commits)
  Bump API schema to f203c35d (#13523)
  Update index.mdx (#13345)
  feat(toggle): Adding docs for the toggle command (#13487)
  feat(Unity): Added `trace ID` connecting error explainer  (#13516)
  feat(Unity): Editor Facelift (#13514)
  feat(Unity): Updated `options` and error capture explainer (#12904)
  Add data collected page for KMP (#13485)
  adjust language to be clear on developer privacy responsability (#13502)
  Factory and Teamcamp integrations (#13365)
  feat: More clearly document log envelope item in logs spec (#13501)
  Small improvements to `traces_sampler` configuration.  (#13470)
  docs(js): Further clarify `denyUrls` (#13481)
  fix(js): Update `denyUrls` text in filtering page (#13494)
  docs(js): Fix uglify example command (#13329)
  chore(legal): Add note about how users are identified on Mobile (#13465)
  feat(native): add data collected page (#13483)
  ref(sourcemaps): Add faulty community-maintained packages to troubleshooting doc (#12915)
  feat(changelog): Add missing form-textarea class to editor (#12893)
  Remove 'Set Up' prefix from sidebar titles across all platforms (#13392)
  Bump API schema to 7028abc0 (#13490)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants