Skip to content

docs(relay): remove entries that are not scrubbed by default #13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

Litarnus
Copy link
Contributor

DESCRIBE YOUR PR

This PR removes entries from the list of default scrubbed event properties because they are explicitly ignored in the scrubbing process.
The list of ignored values can be found here: https://github.com/getsentry/relay/blob/master/relay-pii/src/convert.rs#L16

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:00pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2025 2:00pm

Copy link

codecov bot commented Apr 30, 2025

Bundle Report

Changes will decrease total bundle size by 56 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -50 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js -41 bytes 583.09kB -0.01%

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -41 bytes 3.13MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/GE4mvIkRYpr8WrGu2M7_u/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/GE4mvIkRYpr8WrGu2M7_u/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/DAr5fcxwRoPevksV878r8/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/DAr5fcxwRoPevksV878r8/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Litarnus Litarnus merged commit 6486909 into master Apr 30, 2025
11 checks passed
@Litarnus Litarnus deleted the martinl/event-pii-fields branch April 30, 2025 14:18
codyde added a commit that referenced this pull request May 1, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  Add "Data Collected" page for Godot SDK (and more) (#13533)
  Clarify FK docs (#13562)
  Clarify db index docs (#13561)
  Remove non-functioning video embed (#13557)
  Masinette integrations elba (#13503)
  Incorporate Uptime Monitors Into The Crons Management Page (#13507)
  feat(javascript): Add "Data Collected" (#13527)
  docs(relay): remove entries that are not scrubbed by default (#13555)
  flutter: Add note to app start integration (#13479)
  ref(flutter): move custom zone handling code snippet from init to troubleshooting (#13478)
  docs(python): add uv option to python install instructions (#13510)
  add docs for supabase integration (#13545)
  feat(native): add view hierarchy to develop docs (#13544)
  feat(autofix): Update autofix images (#13540)
  Ad alerts and dashboard page to new quickstart guide (#13522)
  Add data enrichment page to new onboarding guide (#13508)
  Add first onboarding guide to docs (#13462)
  (feat) Sentry MCP Documentation  (#13524)
  feat(Capacitor): Migration guides for version 2 (#13022)
  docs(js): move API-related content from Manual Setup to APIs page (#13327)
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants