-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(sourcemaps): Add more sourcemaps docs #6667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lizokm
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few small suggestions.
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/sourcemaps/artifact-and-release-bundles/javascript.mdx
Outdated
Show resolved
Hide resolved
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
…javascript.mdx Co-authored-by: Liza Mock <[email protected]>
Thanks a lot @lizokm. You even went back into the sentry-cli guide to make terminology consistent! |
Jesse-Box
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs explaining the differences between artifact and release bundles.
Closes: getsentry/sentry#47221