Skip to content

replay: iframe srcdoc block #7046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia requested review from a team May 29, 2023 21:08
@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 6:41pm

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewording and making the link specific to the blocking section

@bruno-garcia
Copy link
Member Author

Thanks @shanamatthews

@bruno-garcia bruno-garcia enabled auto-merge (squash) May 30, 2023 21:33
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably by default block iframe[srcdoc]

@bruno-garcia bruno-garcia merged commit 4942caa into master Jun 5, 2023
@bruno-garcia bruno-garcia deleted the replay/block-iframe-srcdoc branch June 5, 2023 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants