-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(alerts): Add new common tags #7088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -86,7 +86,7 @@ For some metric alerts, you can set the event type that you want to be alerted a | |||
Add filters in the provided input to narrow down what you'll be alerted about, such as URL tags or other event properties. Available properties depend on your alert's event type: | |||
|
|||
- for **error** events, all error properties are available. See [Searchable Properties](/product/sentry-basics/search/searchable-properties/#event-properties) for a full list | |||
- for **transaction** events, only five properties are available: `release`, `transaction`, `transaction.status`, `transaction.op`, and `http.method`. | |||
- for **transaction** events, only five properties are available: `release`, `transaction`, `transaction.status`, `transaction.op`, `browser.name`, `os.name`, `geo.country_code`, `http.status_code`, and `http.method`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- for **transaction** events, only five properties are available: `release`, `transaction`, `transaction.status`, `transaction.op`, `browser.name`, `os.name`, `geo.country_code`, `http.status_code`, and `http.method`. | |
- for **transaction** events, only the following properties are available: `release`, `transaction`, `transaction.status`, `transaction.op`, `browser.name`, `os.name`, `geo.country_code`, `http.status_code`, and `http.method`. |
This reverts commit dc96622.
Hey there, the release date of this feature has been pushed from 6/2 to 6/21 so we reverted your commit. @olksdr we would super appreciate it if the docs team had a chance to review PRs before they get merged in the future :) Thank you! |
Hey @lizokm, sorry, it's my bad! And thanks for taking care of this. |
@lizokm would it make sense to make @getsentry/docs a code owner and setup the repository to require code owner reviews then? |
To my mind, we don't have to put hard guardrails up :) I think it's enough to have an unofficial agreement. It seems to be working well for the most part. But will definitely keep this idea in mind if it begins to seem necessary. |
Add new common tags to the metric alerts.
This adds:
os.name
browser.name
geo.country_code
http.status_code