Skip to content

feat(js): Restructure tree shaking docs #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat(js): Restructure tree shaking docs #9654

merged 2 commits into from
Apr 17, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 10, 2024

This moves the sections around a bit, leading with the bundler plugins instructions now, as they are the easiest to do.

Side note: Currently we do not show the bundler plugin docs for next, sveltekit, remix and astro. For next we have dedicated docs, which seems OK. But, can/should we show bundler plugin docs for these platforms as well? Or is this not possible? cc @Lms24 & @lforst

This moves the sections around a bit, leading with the bundler plugins instructions now, as they are the easiest to do.
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad April 10, 2024 11:01
@mydea mydea self-assigned this Apr 10, 2024
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 9:12am

Copy link

codecov bot commented Apr 10, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.19MB 3 bytes ⬇️
sentry-docs-client 5.52MB 6 bytes ⬇️
sentry-docs-edge-server 442.15kB 3 bytes ⬇️

@Lms24
Copy link
Member

Lms24 commented Apr 10, 2024

Side note: Currently we do not show the bundler plugin docs for next, sveltekit, remix and astro. For next we have dedicated docs, which seems OK. But, can/should we show bundler plugin docs for these platforms as well? Or is this not possible? cc @Lms24 & @lforst

Opened an issue to track: getsentry/sentry-javascript#11531

@lizokm lizokm self-requested a review April 10, 2024 21:14
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small tweaks, but this looks good!

@mydea mydea merged commit 0a48f88 into master Apr 17, 2024
6 checks passed
@mydea mydea deleted the fn/tree-shaking branch April 17, 2024 09:15
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants