Skip to content

feat: View Hierarchy #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 2, 2025
Merged

feat: View Hierarchy #143

merged 33 commits into from
May 2, 2025

Conversation

limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented Mar 17, 2025

This PR implements automatic capturing of scene tree hierarchy data. In Sentry, this feature is more commonly known as View Hierarchy. It's an opt-in feature that can be enabled by setting the attach_scene_tree option to true.

Implements #113
Resolves #166

Waiting for the product changes:

Depends on:

Documentation PR:

Remaining tasks:

  • Add docs
Screenshot 2025-04-28 at 09 36 55

Copy link
Contributor

github-actions bot commented Mar 17, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 849c540

@limbonaut limbonaut force-pushed the feat/view-hierarchy branch from df48641 to 1f90068 Compare March 17, 2025 21:47
@limbonaut limbonaut force-pushed the feat/view-hierarchy branch from 436a0ef to ae0c018 Compare March 20, 2025 18:55
@limbonaut limbonaut force-pushed the feat/view-hierarchy branch 2 times, most recently from 8b17e17 to b819227 Compare April 1, 2025 17:03
@limbonaut limbonaut force-pushed the feat/view-hierarchy branch 2 times, most recently from a8b8010 to 5e1f1ad Compare April 3, 2025 14:48
@limbonaut limbonaut force-pushed the feat/view-hierarchy branch from 5e1f1ad to f8b92a5 Compare April 3, 2025 14:48
@limbonaut limbonaut force-pushed the feat/view-hierarchy branch from 6a15a7b to dfc87ca Compare April 14, 2025 14:11
@bruno-garcia
Copy link
Member

@bruno-garcia
Copy link
Member

@limbonaut this is unblocked now! exciting! :)

@limbonaut
Copy link
Collaborator Author

I've added a screenshot of view hierarchy as displayed on sentry.io. It works for both errors and crash reports. All we're missing is documentation changes.

@limbonaut limbonaut marked this pull request as draft April 28, 2025 11:15
@limbonaut limbonaut marked this pull request as ready for review April 28, 2025 12:43
@limbonaut
Copy link
Collaborator Author

Documentation added in:

Also, ensuring that capturing is only performed on the main thread plus small fixes.

@limbonaut limbonaut requested a review from bruno-garcia April 28, 2025 14:58
@limbonaut limbonaut merged commit cc7b1ae into main May 2, 2025
26 checks passed
@limbonaut limbonaut deleted the feat/view-hierarchy branch May 2, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sentry_options_add_view_hierarchy to attach view hierarchy to native crashes Add support for View Hierarchy
2 participants