Skip to content

Add custom maven target for unity #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2023
Merged

Add custom maven target for unity #2725

merged 5 commits into from
May 22, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 22, 2023

#skip-changelog

@romtsn romtsn requested review from bitsandfoxes and removed request for markushi, adinauer and stefanosiano May 22, 2023 09:24
@romtsn romtsn changed the title Add custom maven target Add custom maven target for unity May 22, 2023
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3
The sentry-native changes are intentional?

@romtsn
Copy link
Member Author

romtsn commented May 22, 2023

<3 The sentry-native changes are intentional?

nope! will revert

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.01 ⚠️

Comparison is base (46dd45b) 81.11% compared to head (9bf846a) 81.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2725      +/-   ##
============================================
- Coverage     81.11%   81.11%   -0.01%     
- Complexity     4445     4447       +2     
============================================
  Files           345      345              
  Lines         16387    16394       +7     
  Branches       2226     2226              
============================================
+ Hits          13293    13298       +5     
- Misses         2166     2168       +2     
  Partials        928      928              
Impacted Files Coverage Δ
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt 81.18% <80.00%> (-0.73%) ⬇️
...java/io/sentry/apollo3/SentryApollo3Interceptor.kt 64.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit 46b1782 into main May 22, 2023
@romtsn romtsn deleted the rz/feat/unity-artifact branch May 22, 2023 10:54
@romtsn romtsn mentioned this pull request Jul 18, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants