feat: Add experimental module metadata injection #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
reviewed
Jun 28, 2023
|
The newly added e2e tests pass on my machine but don't run in CI from my fork... |
Ah we disabled E2E tests since we introduced debug IDs since the ones we had didn't make sense anymore. Lemme look into this... |
My assumption was that e2e tests are disabled for PRs from external forks since an auth token is used for the |
That too! |
lforst
reviewed
Jul 3, 2023
lforst
reviewed
Jul 3, 2023
lforst
reviewed
Jul 3, 2023
lforst
reviewed
Jul 3, 2023
packages/e2e-tests/scenarios/module-metadata/module-metadata.test.ts
Outdated
Show resolved
Hide resolved
This reverts commit 9dbe23b.
timfish
force-pushed
the
feat/module-metadata
branch
from
3b3bf0b to
703cbdd
Compare
lforst
changed the title
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323
This PR:
moduleMetadatato_experimentsoptionmoduleMetadatahas been setThis PR does not yet pass through
entryPointto the metadata callback as suggested here.