Session Replay Privacy do not work as expected, sentry-mask show full text after changes

[expcapitaldev]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/angular

SDK Version

7.37.1

Framework Version

"@sentry/angular": "7.37.1",

Link to Sentry event

https://currencycom.sentry.io/replays/trading-web-cc-test:dc26c4e893224c83bf227220b3baafdd/?project=5963475&query=&referrer=%2Freplays%2F&statsPeriod=1h&yAxis=count%28%29

SDK Setup

Sentry.init({
  dns: myDNS,
  // set to 1 so once we add the integration, it will def. be sampled
  replaysSessionSampleRate: 1,
  replaysOnErrorSampleRate: 1,
  integrations: []; // not added here
});

 // enableReplay for example from variable from server
async function toggleReplay(enableReplay){
  const client: Client | undefined = Sentry.getCurrentHub().getClient();
  if (!client) {
    return;
  }
  const existingReplay = client.getIntegration(Replay);
  if (enableReplay) {
  
    if (existingReplay) {
      return;
    }
    const replay = new Replay();
    client.addIntegration(replay);
  } else {
     if (existingReplay) {
      await replay.flush();
   replay.stop();
     }
   
  }
}

Steps to Reproduce

1. add sentry-mask css class to input with ngModel or/and to div wrapper
2. change input
3. see your session

Expected Result

Privacy data should have mask after initialization Sentry and after changes

Actual Result

after Sentry init we see mask "*" but after changes we see original text, class did not removed from input/div
(sentry-ignore the same, only sentry-block works as expected)
Pls recheck from your side

[expcapitaldev]

also I see next

[Lms24]

Hi @expcapitaldev thanks for writing in!

Just to confirm: you would like to see the username field staying masked but it is unmasked?

Can you share a minimal example of this input field in which it is not masked correctly? Are you using some sort of component library? It's very hard to debug this without a proper reproduction you you would help us a lot, thanks :)

[expcapitaldev]

Hi!
Just to confirm: you would like to see the username field staying masked but it is unmasked? - yep, confirm.
Do you have demo angular project with Sentry for example in stackblitz or something similar ?

[expcapitaldev]

So, easy, you can add common

<input class="sentry-mask" type="email"/>

and you can see, after initialization we see in sentry replay mask but if I will change input I will show text in Sentry replay, pls confirm from your side

[billyvg]

We ask for a reproduction because environments and configuration varies user to user. You did not include your Replay configuration which have helped as this happens when maskAllInput: false and an input is changed.

I've fixed it here getsentry/rrweb#61 and added a test and will fix in #7260

[expcapitaldev]

Yep,see const replay = new Replay(); need to change to

new Replay({
     maskAllText: false,
     maskAllInputs: false,
     blockAllMedia: false,
})

[billyvg]

@expcapitaldev This should be fixed now in version 7.39.0, please re-open if you're still having issues, thanks!