Skip to content

ref: Deprecate deepReadDirSync #10016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024
Merged

ref: Deprecate deepReadDirSync #10016

merged 2 commits into from
Jan 3, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 2, 2024

This function has absolutely nothing to do with SDK functionality and isn't used anywhere except for our Next.js tests (?).

@lforst lforst requested review from AbhiPrasad and mydea January 2, 2024 15:57
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we add that test-utils package finally.

Copy link
Contributor

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of context but good to discuss: Can we also have a lint rule like biome-ignore does and explain why we deprecated and disabled the line per change?

Copy link
Contributor

github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.96 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.4 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.09 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.24 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 204.14 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 94.03 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.21 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.78 KB (0%)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.43 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.06 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

@lforst lforst merged commit 651ef4a into develop Jan 3, 2024
@lforst lforst deleted the lforst-deprecation-sweep branch January 3, 2024 15:21
anonrig pushed a commit that referenced this pull request Jan 3, 2024
AbhiPrasad added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants