fix: Handle custom error names in TraceKit #1237
Conversation
vendor/TraceKit/tracekit.js
Outdated
| function computeStackTraceFromStackProp(ex) { | ||
| if (typeof ex.stack === 'undefined' || !ex.stack) return; | ||
|
|
||
| var chrome = /^\s*at (.*?) ?\(((?:file|https?|blob|chrome-extension|native|eval|webpack|<anonymous>|[a-z]:|\/).*?)(?::(\d+))?(?::(\d+))?\)?\s*$/i, | ||
| gecko = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)((?:file|https?|blob|chrome|webpack|resource|\[native).*?|[^@]*bundle)(?::(\d+))?(?::(\d+))?\s*$/i, | ||
| gecko = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)((?:file|https?|blob|chrome|webpack|resource).*?:\/.*?|\[native code\]|[^@]*bundle)(?::(\d+))?(?::(\d+))?\s*$/i, |
There was a problem hiding this comment.
pretty sure blob is blob:foo and not blob://fo
There was a problem hiding this comment.
Blob is blob:http://url/for/some/endpoint, which is matched by blob.*?:\/:) We have a test for it in place
There was a problem hiding this comment.
That depends on the browser. Current chrome adds the http origin to it, but blob:UUID is perfectly permissible and shows up in Firefox for instance.
You can try with (URL.createObjectURL(new Blob([new Int8Array()]))).toString()
There was a problem hiding this comment.
Apparently blob urls are now supposed to always have an origin. Since they are rare I might be okay with that but please add a comment why blob is okay.
There was a problem hiding this comment.
Added appropriate note and reformatted variables slightly so it's easier to move around.
There was a problem hiding this comment.
Also made it two separate commits so it's easier to track precise changes
kamilogorek
force-pushed
the
tracekit-custom-errors
branch
2 times, most recently
from
14489ea to
1cc1915
Compare
kamilogorek
force-pushed
the
tracekit-custom-errors
branch
from
1cc1915 to
845c83b
Compare
Fixes #1209 (comment)