-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(tracing): add long animation frame tracing #12646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
2083357
to
d4ff07d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a link/screenshot of an example trace with these spans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to test the scenarios where:
enableLongAnimationFrame
is true, but non-chromium browserenableLongAnimationFrame
is false andenableLongTask
is true
afterwards we are good to merge. Thanks for sticking with this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to adjust https://github.com/getsentry/sentry-javascript/blob/develop/.size-limit.js - you can run yarn size-limit
in the root after you run yarn build
to see what to change.
I also updated #11719 with a tasklist of follow up items. Do you have the item to do these?
You can ignore Secret Scan as well! Please make sure to |
Adds an option to trace long animation frames as per #11719. This tracing feature is disabled by default.
Currently, this feature https://developer.mozilla.org/en-US/docs/Web/API/Performance_API/Long_animation_frame_timing is only supported by Chromium browsers.
Usage is opt-in: