chore: Remove replace-in-file and inquirer #12687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
chargome and
nicohrubec
and removed request for
a team
chargome
approved these changes
Jun 28, 2024
AbhiPrasad
force-pushed
the
abhi-replace-in-file
branch
from
74edf49 to
6449fb4
Compare
AbhiPrasad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #12644
We can remove
replace-in-fileandinquirerwith some built-in functions and clean up our lockfile even more.Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.