-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref: Expose Raven's constructor publicly. Kinda. #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0274c20
to
f5ca2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be worth prefixing this with _ to act as more warning? The comment is good but the name isn't "scary" on it's own like "dangerouslysetinnerhtml" or something
@MaxBittker I wanted it to be in line with node's implementation for now. It'll be updated and taken care of correctly in v4 :) |
@kamilogorek thanks for the super-fast delivery! |
Quick question on this documentation @kamilogorek Rather than
shouldn't it be:
|
@dmk255 ah! Yes, thank you. I forgot the Updated: f3b3500 |
@kamilogorek Quick follow up on that though. I haven't had that issue in my local testing with multiple install calls. That said, I am using webpack code chunking and only call Is there is a subtly that I'm missing or am I fine so long as I ensure that |
What Everything I said is true only when you actually rely on handlers and don't just use |
Resolves: #1269