build: Pin to Node 22.4 #12980
Merged
build: Pin to Node 22.4 #12980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
chargome and
nicohrubec
and removed request for
a team
nicohrubec
approved these changes
Jul 18, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Jul 24, 2024
This reverts commit edf4ac4.
AbhiPrasad
added a commit
that referenced
this pull request
Jul 24, 2024
Reverts #12980 We no longer need to pin to Node 22.4 now that Node 22.5.1 has been released. https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's pin to Node
22.4- there's a regression with22.5that affects us nodejs/node#53902We can revert this pin after they do a Node.js release.