Skip to content

feat(node): Add kafkajs integration #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Resolves: #13314

Copy link
Contributor

github-actions bot commented Aug 29, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.52 KB - -
@sentry/browser - with treeshaking flags 21.3 KB - -
@sentry/browser (incl. Tracing) 34.78 KB - -
@sentry/browser (incl. Tracing, Replay) 71.23 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.67 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.58 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.3 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.14 KB - -
@sentry/browser (incl. metrics) 26.83 KB - -
@sentry/browser (incl. Feedback) 39.6 KB - -
@sentry/browser (incl. sendFeedback) 27.19 KB - -
@sentry/browser (incl. FeedbackAsync) 31.9 KB - -
@sentry/react 25.28 KB - -
@sentry/react (incl. Tracing) 37.75 KB - -
@sentry/vue 26.72 KB - -
@sentry/vue (incl. Tracing) 36.67 KB - -
@sentry/svelte 22.65 KB - -
CDN Bundle 23.77 KB - -
CDN Bundle (incl. Tracing) 36.5 KB - -
CDN Bundle (incl. Tracing, Replay) 70.91 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.22 KB - -
CDN Bundle - uncompressed 69.63 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.25 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.91 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.11 KB - -
@sentry/nextjs (client) 37.51 KB - -
@sentry/sveltekit (client) 35.36 KB - -
@sentry/node 123.87 KB +0.94% +1.15 KB 🔺
@sentry/node - without tracing 96.22 KB - -
@sentry/aws-serverless 105.74 KB - -

View base workflow run

@onurtemizkan onurtemizkan marked this pull request as ready for review August 29, 2024 22:48

const INTEGRATION_NAME = 'Kafka';

// Todo: Check if we can use the hooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this todo still apply?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, removed it 👍

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share an example trace from this integration?

Also does this work in esm? or is kafka-js cjs only?

@onurtemizkan
Copy link
Collaborator Author

Could you share an example trace from this integration?

Sure -> Link

Also does this work in esm? or is kafka-js cjs only?

kafka-js is currently CJS only (Ref)

@onurtemizkan onurtemizkan force-pushed the onur/kafka-integration branch from e582463 to 6166492 Compare September 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kafkaIntegration to Node
2 participants