Skip to content

test(react): Ensure react router 3 tests always have correct types #14949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 9, 2025

Noticed this failing every now and then locally. After looking into this, I found this to be a bit weird anyhow:

  1. We used react-router-5 types for react-router 4, seems off 🤔 I adjusted this to v4
  2. We used to add the @types/react-router-v3 alias in package.json, but this was not being picked up anyhow properly. The reason is that this version of the types package basically re-exports a bunch of stuff from a path like react-router/lib which our resolution then sometimes (?) picks up from the v6 react-router package. Which is also why we had to overwrite this somehow, which is what sometimes failed (?). Now, we simply define these types in test/globals.d.ts properly, the same way as before, but there should be no more conflicts and we can safe installing one unecessary package.

@mydea mydea self-assigned this Jan 9, 2025
@mydea mydea merged commit fc6d51c into develop Jan 9, 2025
157 checks passed
@mydea mydea deleted the fn/better-react-router-3-test branch January 9, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants