test(react): Ensure react router 3 tests always have correct types #14949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this failing every now and then locally. After looking into this, I found this to be a bit weird anyhow:
@types/react-router-v3
alias in package.json, but this was not being picked up anyhow properly. The reason is that this version of the types package basically re-exports a bunch of stuff from a path likereact-router/lib
which our resolution then sometimes (?) picks up from the v6 react-router package. Which is also why we had to overwrite this somehow, which is what sometimes failed (?). Now, we simply define these types in test/globals.d.ts properly, the same way as before, but there should be no more conflicts and we can safe installing one unecessary package.