Skip to content

ref(nextjs): Remove metadata builder class #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

AbhiPrasad
Copy link
Member

Refactor the class into functions to save on bundle size. Extracted from
changes in #4196.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021

size-limit report

Path Base Size (010d37f) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.44 KB 22.44 KB +0.02% 🔺
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/browser - Webpack - gzip = false 82.62 KB 82.62 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 48.03 KB 47.96 KB -0.15% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.96 KB 29.96 KB 0%

Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests, why are we deleting them?

Refactor the class into functions to save on bundle size. Extracted from
changes in #4196.
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 14, 2021 17:31
@AbhiPrasad AbhiPrasad merged commit e6a300b into master Dec 14, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-metdata-builder-next branch December 14, 2021 17:46
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
* ref(nextjs): Remove metadata builder class

Refactor the class into functions to save on bundle size. Extracted from
changes in #4196.

* add tests for nextjs metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants