Skip to content

build(browser): Add back debug func to CDN bundle #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

Temporarily stop removing debug functionality from the CDN bundle while
we work on a more fleshed out bundling solution.

We previously added static globals in
#4273 to leverage
dead code elimination to remove debug functionality from the browser
CDN. Currently though, we only publish a single CDN bundle, the one that
has the debug functionality stripped. Until we publish seperate CDN
bundles for debug and production, we will disable stripped debug
functionality from the production bundle.

Temporarily stop removing debug functionality from the CDN bundle while
we work on a more fleshed out bundling solution.

We previously added static globals in
#4273 to leverage
dead code elimination to remove debug functionality from the browser
CDN. Currently though, we only publish a single CDN bundle, the one that
has the debug functionality stripped. Until we publish seperate CDN
bundles for debug and production, we will disable stripped debug
functionality from the production bundle.
@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Jan 19, 2022
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (4fec3b3) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.58 KB 19.59 KB +0.03% 🔺
@sentry/browser - CDN Bundle (minified) 62.5 KB 62.5 KB +0.01% 🔺
@sentry/browser - Webpack 22.11 KB 22.11 KB 0%
@sentry/browser - Webpack - gzip = false 75.59 KB 75.59 KB 0%
@sentry/react - Webpack 22.14 KB 22.14 KB 0%
@sentry/nextjs Client - Webpack 46.33 KB 46.33 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.31 KB 28.31 KB +0.01% 🔺

@AbhiPrasad AbhiPrasad merged commit 2fcf480 into master Jan 19, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-debug-cdn branch January 19, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants