ref(client): Inject Transports into Client #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Apr 12, 2022
size-limit report 📦
|
Lms24
changed the title
Lms24
force-pushed
the
lms-inject-transports
branch
2 times, most recently
from
2275534 to
0c9e746
Compare
Lms24
changed the title
all tests will need refactoring once the new transports become the default
Lms24
force-pushed
the
lms-inject-transports
branch
from
d759f7a to
86cfd73
Compare
lforst
approved these changes
Apr 14, 2022
| * this function will return a ready to use `NewTransport`. | ||
| */ | ||
| // TODO(v7): Adjust return value when NewTransport is the default | ||
| export function setupNodeTransport(options: NodeOptions): { transport: Transport; newTransport?: NewTransport } { |
There was a problem hiding this comment.
Requires no action now but we should think about moving the contents of this function back into the init function when we get rid of the old transports. Reason being that this function will be reduced to about 5 lines, making it just a weird proxy for makeNodeTransport.
Same goes for setupBrowserTransport. Although I do realize we have just written tests for those functions... 🤔
There was a problem hiding this comment.
Yes these setupXTransport functions will get much smaller, once the old transports are removed, agreed. Let's see how/where we handle ClientOptions. This will probably be the place to set up transports then (or pass on a custom one).
There was a problem hiding this comment.
And regarding setup tests: They don't have to stay. I just quickly added them to test setup functionality explicitly. Kinda makes sense at least for fetch vs xhr on the browser side IMO. But let's see if/where they stay when we declutter/restructure the transport setup
packages/node-integration-tests/suites/sessions/errored-session-aggregate/test.ts
Outdated
Show resolved
Hide resolved
lforst
approved these changes
Apr 14, 2022
AbhiPrasad
approved these changes
Apr 14, 2022
Lms24
added a commit
that referenced
this pull request
Apr 26, 2022
Changes the way we initialize Transports. Previously, the Transport was initialized within the Client constructor (by calling setupTransport()). Change this so that the Transport is initialized beforehand and then injected into the client. This is currently (i.e. with this PR) happening via two additional arguments in the Client class constructors. The reason for two arguments is that we're still using both, the old `Transport` classes and the `NewTransport` interface. In the future, `NewTransport` will replace `Transport` and (once the old Transport is removed) the transport is then passed into the Client constructor as a property of the options object. * add the injection logic * initialize the transports in Browser and Node and pass them to the `Browser/NodeClient` initialization * add client-external transport setup functions (extracted from setupTransport()) * add basic tests for these transport setup functions * delete the client-internal setupTransport methods * fixe a bunch of tests that are initializing clients
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Changes the way we initialize Transports. Previously, the Transport was initialized within the Client constructor (by calling setupTransport()). Change this so that the Transport is initialized beforehand and then injected into the client. This is currently (i.e. with this PR) happening via two additional arguments in the Client class constructors. The reason for two arguments is that we're still using both, the old `Transport` classes and the `NewTransport` interface. In the future, `NewTransport` will replace `Transport` and (once the old Transport is removed) the transport is then passed into the Client constructor as a property of the options object. * add the injection logic * initialize the transports in Browser and Node and pass them to the `Browser/NodeClient` initialization * add client-external transport setup functions (extracted from setupTransport()) * add basic tests for these transport setup functions * delete the client-internal setupTransport methods * fixe a bunch of tests that are initializing clients
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Changes the way we initialize Transports. Previously, the Transport was initialized within the Client constructor (by calling setupTransport()). Change this so that the Transport is initialized beforehand and then injected into the client. This is currently (i.e. with this PR) happening via two additional arguments in the Client class constructors. The reason for two arguments is that we're still using both, the old `Transport` classes and the `NewTransport` interface. In the future, `NewTransport` will replace `Transport` and (once the old Transport is removed) the transport is then passed into the Client constructor as a property of the options object. * add the injection logic * initialize the transports in Browser and Node and pass them to the `Browser/NodeClient` initialization * add client-external transport setup functions (extracted from setupTransport()) * add basic tests for these transport setup functions * delete the client-internal setupTransport methods * fixe a bunch of tests that are initializing clients
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Changes the way we initialize Transports. Previously, the Transport was initialized within the Client constructor (by calling setupTransport()). Change this so that the Transport is initialized beforehand and then injected into the client. This is currently (i.e. with this PR) happening via two additional arguments in the Client class constructors. The reason for two arguments is that we're still using both, the old `Transport` classes and the `NewTransport` interface. In the future, `NewTransport` will replace `Transport` and (once the old Transport is removed) the transport is then passed into the Client constructor as a property of the options object. * add the injection logic * initialize the transports in Browser and Node and pass them to the `Browser/NodeClient` initialization * add client-external transport setup functions (extracted from setupTransport()) * add basic tests for these transport setup functions * delete the client-internal setupTransport methods * fixe a bunch of tests that are initializing clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we initialize Transports. Previously, the Transport was initialized within the Client constructor (by calling
setupTransport()). With this PR, we change this so that the Transport is initialized beforehand and then injected into the client. This is currently (i.e. with this PR) happening via two additional arguments in theClientclass constructors. The reason for two arguments is that we're still using both, the oldTransportclasses and theNewTransportinterface. In the future,NewTransportwill replaceTransportand (once the old Transport is removed) the transport is then passed into the Client constructor as a property of theoptionsobject.Specifically, this PR
Browser/NodeClientinitializationsetupTransport())setupTransportmethodsref: https://getsentry.atlassian.net/browse/WEB-792