-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta: 7.0.0-beta.0 CHANGELOG #5011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e4fbb11
meta: 7.0.0-beta.0 CHANGELOG
AbhiPrasad 7854fa1
add migration docs for client options
AbhiPrasad 0838d0d
Apply suggestions from code review
AbhiPrasad c8335e8
Remove changes in migration docs
lforst a44657b
Update changelog with #5015
lforst d8ff2c0
Clarify item in changelog
lforst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be careful using
PascalCase
naming when the intention is doing a function call.It is easy to miss that they are technically functions and assume that they are constructors and people adding
new BrowserClient(...)
. And the worst is that it is "technically correct" from the perspective of the runtime (but wrong based on the usage, and intention).I will recommend to do
makeBrowserClient
orbrowserClient
ornewBrowserClient
but avoidPascalCase
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, this is my bad.
BrowserClient
is still a class for now - so there should be thenew
keyword here - we'll maybe revisit this at a later time though,