Skip to content

fix(sveltekit): Make handleErrorWithSentry parameter optional in function declaration #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 16, 2023

Noticed while testing that the parameter (i.e. the user handler) is optional in the implementation but not in the isomorphic declaration.

ref #7402 #7403

@Lms24 Lms24 requested a review from AbhiPrasad March 16, 2023 15:46
@Lms24 Lms24 enabled auto-merge (squash) March 16, 2023 15:48
@Lms24 Lms24 merged commit be56361 into develop Mar 16, 2023
@Lms24 Lms24 deleted the lms/fix-sveltekit-handleErrorWithSentry-type branch March 16, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants