feat(core): Add sampling decision to trace envelope header #8483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-sampling-decision-trace-env
branch
from
e8e2180 to
2e06d84
Compare
AbhiPrasad
requested review from
a team,
stephanie-anderson and
lforst
and removed request for
a team
AbhiPrasad
commented
Jul 11, 2023
| // Uncomment if we want to make DSC immutable | ||
| // this._frozenDynamicSamplingContext = dsc; | ||
|
|
||
| client.emit && client.emit('createDsc', dsc); |
There was a problem hiding this comment.
Removed this because getDynamicSamplingContextFromClient already emits createDsc on the client as a side effect, so no need to duplicate it.
mydea
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8482
To save on bundle size, we only add
sampledto the DSC if there is an active transactionThis matches https://github.com/getsentry/relay/blob/11f1ab455e2d5abc11d05776f8ec4a83cfd8c66e/relay-general/src/protocol/contexts/trace.rs#L109-L112