fix(replay): Handle errors in `beforeAddRecordingEvent` callback #8548

mydea · 2023-07-17T08:43:33Z

When an error occurs in beforeAddRecordingEvent, we just skip this event and log the error.

github-actions · 2023-07-17T08:51:42Z

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	21.95 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)	69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified)	60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified)	21.9 KB (0%)
@sentry/browser - Webpack (minified)	71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified)	21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)	50.58 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	30.11 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	28.16 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)	49.43 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified)	43.15 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	69.51 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	61.83 KB (+0.02% 🔺)

mydea requested a review from billyvg July 17, 2023 08:43

mydea self-assigned this Jul 17, 2023

Lms24 approved these changes Jul 17, 2023

View reviewed changes

mydea force-pushed the fn/handle-beforeAddRecordingEvent-error branch from e06952a to df40646 Compare July 17, 2023 09:38

fix(replay): Handle errors in beforeAddRecordingEvent callback

90bda07

mydea force-pushed the fn/handle-beforeAddRecordingEvent-error branch from df40646 to 90bda07 Compare July 17, 2023 11:42

mydea merged commit c2b1bfd into develop Jul 17, 2023

mydea deleted the fn/handle-beforeAddRecordingEvent-error branch July 17, 2023 12:04