Skip to content

Avoid collision if another package has bound 'sentry' #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KarlCastle
Copy link
Contributor

Resolves #466

@stayallive
Copy link
Collaborator

Hey @KarlCastle, great catch, sorry this was missed (by probably me).

Out of curiosity, why are you changing the sentry name. I didn't think there were any (active) packages left also using sentry as a container key.

But again thanks for reporting and even fixing, I've added a few more replacements, let me know if you think (or can double check) I didn't make it worse 😉

@stayallive stayallive added the bug label Mar 24, 2021
@KarlCastle
Copy link
Contributor Author

I'm supporting a legacy application that still relies on cartalyst/sentry. So I'm not aware of any active packages left either :)

Your changes seem great. 👍

@stayallive
Copy link
Collaborator

Haha, sounds about right :) Well in that case thanks for taking the time to report and fix anyway 👍

@stayallive stayallive merged commit cc71ebb into getsentry:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes from #419 are not compatible with projects that change the BaseServiceProvider::$abstract
2 participants