-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows merging user context on Scope::setUser() #931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR! LGTM 👍
I just noticed that this PR is pointing to the wrong branch. Since it’s not a bug fix it should target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small documentation nitpick but looks solid! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and the patience, very good work! LGTM
this seems to not have been part of the PR - what is the recommended way now to set a user to specific value without merging? |
If you mean how you can remove an item from the root of the user context, there is no way to do it now. If you need to push some data and clear it after some operation finished the recommended way is to use a new scope with |
So, how I need to set up user data when I try to initialize Sentry manualy in my project ? |
It depends on what you are trying to do. Please take a look at the documentation, and if something is not clear feel free to open a new issue and/or write to the support |
Closes #929
Scope::setUser
behaviour of replacing user data. (Allow merging user data on Scope #929)Scope::setUser
to allow merging user context. (Allow merging user data on Scope #929)Scope::clearUser
method to clear user context. (Allow merging user data on Scope #929)