Skip to content

Commit ce0727f

Browse files
authored
Fix flaky test (#4198)
There's a test in `test_utils.py` that flakes very often, but only on Python 3.8 and only in CI (locally it's all fine). I've tried a couple of ways to fix it but at this point it's not worth the effort, so just skipping it on 3.8.
1 parent 984f29a commit ce0727f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: tests/test_utils.py

+2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import pytest
88

99
import sentry_sdk
10+
from sentry_sdk._compat import PY38
1011
from sentry_sdk.integrations import Integration
1112
from sentry_sdk._queue import Queue
1213
from sentry_sdk.utils import (
@@ -901,6 +902,7 @@ def target():
901902
assert (main_thread.ident, main_thread.name) == results.get(timeout=1)
902903

903904

905+
@pytest.mark.skipif(PY38, reason="Flakes a lot on 3.8 in CI.")
904906
def test_get_current_thread_meta_failed_to_get_main_thread():
905907
results = Queue(maxsize=1)
906908

0 commit comments

Comments
 (0)