Skip to content

Fix flaky test #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Fix flaky test #4198

merged 7 commits into from
Mar 26, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 25, 2025

There's a test in test_utils.py that flakes very often, but only on Python 3.8 and only in CI (locally it's all fine). I've tried a couple of ways to fix it but at this point it's not worth the effort, so just skipping it on 3.8.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (984f29a) to head (278baa4).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4198      +/-   ##
==========================================
- Coverage   79.58%   79.57%   -0.02%     
==========================================
  Files         141      141              
  Lines       15737    15737              
  Branches     2675     2675              
==========================================
- Hits        12525    12522       -3     
- Misses       2367     2369       +2     
- Partials      845      846       +1     

see 2 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review March 25, 2025 14:20
@sentrivana sentrivana requested a review from a team as a code owner March 25, 2025 14:20
@sentrivana sentrivana merged commit ce0727f into master Mar 26, 2025
140 checks passed
@sentrivana sentrivana deleted the ivana/fix-flaky-test branch March 26, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants