ref(api): Type hinting for start_transaction kwargs #2787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix syntax errors. Class TypedDict syntax is not supported in old Pythons! |
|
Closed in favor of #2796, which applies these changes on the 2.0 branch (getting TypedDict to work in the way I would like it to here would be extremely difficult below Python 3.6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds be type hints for the
**kwargsthat can be passed tosentry_sdk.start_transaction, thereby clearly documenting the parameters that can be passed directly in the code.Ref getsentry/sentry-docs#5082
TransactionKwargstype that this PR introduces.