-
Notifications
You must be signed in to change notification settings - Fork 535
feat(profiling): Introduce continuous profiling mode #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sentrivana
merged 47 commits into
master
from
txiao/feat/introduce-continuous-profiling-mode
Jun 11, 2024
Merged
feat(profiling): Introduce continuous profiling mode #2830
sentrivana
merged 47 commits into
master
from
txiao/feat/introduce-continuous-profiling-mode
Jun 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new profiling mode that is mutually exclusive from the existing profiling modes. In the current profiling modes, a profile is always directly attached to a transaction. This new mode will continuously emit chunks of profiling data that will be connected to the span data.
Zylphrex
added a commit
that referenced
this pull request
Mar 18, 2024
As per getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.
Zylphrex
added a commit
that referenced
this pull request
Mar 20, 2024
As per getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.
…o/feat/introduce-continuous-profiling-mode
sentrivana
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but in general looks great to me
…o/feat/introduce-continuous-profiling-mode
This reverts commit ed66f59.
Zylphrex
commented
Jun 6, 2024
sentrivana
approved these changes
Jun 10, 2024
Zylphrex
added a commit
that referenced
this pull request
Jun 11, 2024
The thread data was added to the profile context in #2830. It should live in the trace context to align with other SDKs.
sentrivana
pushed a commit
that referenced
this pull request
Jun 12, 2024
The thread data was added to the profile context in #2830. It should live in the trace context to align with other SDKs.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
This is a new profiling mode that is mutually exclusive from the existing profiling modes. In the current profiling modes, a profile is always directly attached to a transaction. This new mode will continuously emit chunks of profiling data that will be connected to the span data.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
The thread data was added to the profile context in getsentry#2830. It should live in the trace context to align with other SDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new profiling mode that is mutually exclusive from the existing profiling modes. In the current profiling modes, a profile is always directly attached to a transaction. This new mode will continuously emit chunks of profiling data that will be connected to the span data.