Update and cleanup Celery integration #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When called manually or via Celery Beat
|
One thing I need to check. In my test project I have two tasks with 1 minute interval. When I start the server (celery with beat) then the Cron monitors work fine. But If I restart the server then the cron monitors have a "missed" state. |
There was a problem hiding this comment.
I read through your changes, but I am having trouble understanding the PR at a high level, so I think it would be better if @sentrivana also reviews this.
sentrivana
approved these changes
Mar 25, 2024
sentrivana
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the Celery integration to make it easier to work on it and also update to the new minimum supported Celery versions and the new Scopes API.
The easiest way to review this is probably looking at the "Fixed trace propagation" commit:
a723cb7
The other commits are mostly moving code around.