Skip to content

ref: Improve start_transaction docs #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

szokeasaurusrex
Copy link
Member

This PR adds documentation for all start_transaction parameters. It also proposes removing the StartTransactionKwargs typeddict, instead placing the custom_sampling_context parameter directly on the method and deleting the client parameter, which appears not to be used.

ref getsentry/sentry-docs#5082

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@szokeasaurusrex szokeasaurusrex merged commit 9e3ae56 into sentry-sdk-2.0 Mar 28, 2024
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/document-start-transaction branch March 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants