Skip to content

feat(tests): Add a Starlette testcase that uses Uvicorn #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 26, 2024

Follow up to detect regressions like #3021. Verified that the new test fails if I reintroduce the async ensure decorator.

The new Uvicorn fixture might be also useful for other tests.

Also took the liberty to update the Starlette versions in Tox.

Relates #2892

WIP: works locally. freezes in ci.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review April 26, 2024 11:18
@sentrivana sentrivana marked this pull request as draft April 26, 2024 12:30
@antonpirker antonpirker added this to the Starlette/FastAPI Update milestone Jun 7, 2024
@antonpirker antonpirker removed this from the Starlette/FastAPI Update milestone Jun 20, 2024
Copy link

codecov bot commented Oct 1, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13523 1 13522 4121
View the top 1 failed tests by shortest run time
tests.integrations.stdlib.test_httplib test_http_timeout
Stack Traces | 61.2s run time
.../integrations/stdlib/test_httplib.py:373: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 6 == 1
E     +6
E     -1

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sentrivana sentrivana closed this Nov 21, 2024
@sentrivana sentrivana deleted the ivana/starlette-tests-with-uvicorn branch December 17, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants