-
Notifications
You must be signed in to change notification settings - Fork 536
feat(integrations): Support Django 5.1 #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!! Thx.
Oh... The failing tests are https://docs.djangoproject.com/en/dev/releases/5.1/#miscellaneous -- Might need a skipif
The undocumented django.urls.converters.get_converter() function is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3207 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 133 133
Lines 14290 14290
Branches 3004 3004
=======================================
Hits 11355 11355
Misses 2089 2089
Partials 846 846 |
Something like: @pytest.mark.skipif(
django.VERSION >= (5, 1)
reason="django.urls.converters.get_converter() function was removed in Django v5.1",
) https://docs.djangoproject.com/en/dev/releases/5.1/#miscellaneous
|
Co-authored-by: Christian Clauss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This reverts commit d6b567f.
Co-authored-by: Christian Clauss <[email protected]>
Summary of changes:
5.1b1
get_converter
in tests since this was removed:Also did some manual tests, stuff looks ok.
Closes #3208