Skip to content

ref(logging): Lower logger level for some messages #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2024
Merged

ref(logging): Lower logger level for some messages #3305

merged 5 commits into from
Jul 22, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 18, 2024 •
edited
Loading

These messages might blow up in volume, as we've observed ourselves in Sentry. This might end up clogging up users' logs and increasing their spending.

WIP: look at if there's more cases where it makes sense to lower the log level

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 18507 tests with 24 failed, 16130 passed and 2353 skipped.

View the full list of failed tests

py3.10-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.10.14.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.10.14.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.10-gevent

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.10.14.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.11-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.11.9.../x64/lib/python3.11/unittest/mock.py:950: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.11.9.../x64/lib/python3.11/unittest/mock.py:950: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.11-gevent

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.11.9.../x64/lib/python3.11/unittest/mock.py:950: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.12-common

  • Class name: tests.test_utils
    Test name: test_installed_modules

    tests/test_utils.py:538: in test_installed_modules
        assert installed_distributions == importlib_distributions
    E   AssertionError: assert {'asttokens': '2.4.1',\n 'attrs': '23.2.0',\n 'certifi': '2024.7.4',\n 'charset-normalizer': '3.3.2',\n 'colorama': '0.4.6',\n 'coverage': '7.6.0',\n 'docopt': '0.6.2',\n 'executing': '2.0.1',\n 'idna': '3.7',\n 'iniconfig': '2.0.0',\n 'jsonschema': '4.23.0',\n 'jsonschema-specifications': '2023.12.1',\n 'markupsafe': '2.1.5',\n 'packaging': '24.1',\n 'pip': '24.0',\n 'pluggy': '1.5.0',\n 'py': '1.11.0',\n 'pyrsistent': '0.20.0',\n 'pysocks': '1.7.1',\n 'pytest': '6.2.5',\n 'pytest-asyncio': '0.20.3',\n 'pytest-cov': '5.0.0',\n 'pytest-forked': '1.6.0',\n 'pytest-localserver': '0.8.1',\n 'pytest-watch': '4.2.0',\n 'pyyaml': '6.0.1',\n 'referencing': '0.35.1',\n 'requests': '2.32.3',\n 'responses': '0.25.3',\n 'rpds-py': '0.19.0',\n 'sentry-sdk': '2.10.0',\n 'setuptools': '71.0.2',\n 'six': '1.16.0',\n 'toml': '0.10.2',\n 'urllib3': '2.2.2',\n 'watchdog': '4.0.1',\n 'werkzeug': '3.0.3'} == {'asttokens': '2.4.1',\n 'attrs': '23.2.0',\n 'autocommand': '2.2.2',\n 'backports-tarfile': '1.2.0',\n 'certifi': '2024.7.4',\n 'charset-normalizer': '3.3.2',\n 'colorama': '0.4.6',\n 'coverage': '7.6.0',\n 'docopt': '0.6.2',\n 'executing': '2.0.1',\n 'idna': '3.7',\n 'importlib-metadata': '8.0.0',\n 'importlib-resources': '6.4.0',\n 'inflect': '7.3.1',\n 'iniconfig': '2.0.0',\n 'jaraco-context': '5.3.0',\n 'jaraco-functools': '4.0.1',\n 'jaraco-text': '3.12.1',\n 'jsonschema': '4.23.0',\n 'jsonschema-specifications': '2023.12.1',\n 'markupsafe': '2.1.5',\n 'more-itertools': '10.3.0',\n 'ordered-set': '4.1.0',\n 'packaging': '24.1',\n 'pip': '24.0',\n 'platformdirs': '4.2.2',\n 'pluggy': '1.5.0',\n 'py': '1.11.0',\n 'pyrsistent': '0.20.0',\n 'pysocks': '1.7.1',\n 'pytest': '6.2.5',\n 'pytest-asyncio': '0.20.3',\n 'pytest-cov': '5.0.0',\n 'pytest-forked': '1.6.0',\n 'pytest-localserver': '0.8.1',\n 'pytest-watch': '4.2.0',\n 'pyyaml': '6.0.1',\n 'referencing': '0.35.1',\n 'requests': '2.32.3',\n 'responses': '0.25.3',\n 'rpds-py': '0.19.0',\n 'sentry-sdk': '2.10.0',\n 'setuptools': '71.0.2',\n 'six': '1.16.0',\n 'toml': '0.10.2',\n 'tomli': '2.0.1',\n 'typeguard': '4.3.0',\n 'typing-extensions': '4.12.2',\n 'urllib3': '2.2.2',\n 'watchdog': '4.0.1',\n 'werkzeug': '3.0.3',\n 'wheel': '0.43.0',\n 'zipp': '3.19.2'}
    E     Common items:
    E     {'asttokens': '2.4.1',
    E      'attrs': '23.2.0',
    E      'certifi': '2024.7.4',
    E      'charset-normalizer': '3.3.2',
    E      'colorama': '0.4.6',
    E      'coverage': '7.6.0',
    E      'docopt': '0.6.2',
    E      'executing': '2.0.1',
    E      'idna': '3.7',
    E      'iniconfig': '2.0.0',
    E      'jsonschema': '4.23.0',
    E      'jsonschema-specifications': '2023.12.1',
    E      'markupsafe': '2.1.5',
    E      'packaging': '24.1',
    E      'pip': '24.0',
    E      'pluggy': '1.5.0',
    E      'py': '1.11.0',
    E      'pyrsistent': '0.20.0',
    E      'pysocks': '1.7.1',
    E      'pytest': '6.2.5',
    E      'pytest-asyncio': '0.20.3',
    E      'pytest-cov': '5.0.0',
    E      'pytest-forked': '1.6.0',
    E      'pytest-localserver': '0.8.1',
    E      'pytest-watch': '4.2.0',
    E      'pyyaml': '6.0.1',
    E      'referencing': '0.35.1',
    E      'requests': '2.32.3',
    E      'responses': '0.25.3',
    E      'rpds-py': '0.19.0',
    E      'sentry-sdk': '2.10.0',
    E      'setuptools': '71.0.2',
    E      'six': '1.16.0',
    E      'toml': '0.10.2',
    E      'urllib3': '2.2.2',
    E      'watchdog': '4.0.1',
    E      'werkzeug': '3.0.3'}
    E     Right contains 16 more items:
    E     {'autocommand': '2.2.2',
    E      'backports-tarfile': '1.2.0',
    E      'importlib-metadata': '8.0.0',
    E      'importlib-resources': '6.4.0',
    E      'inflect': '7.3.1',
    E      'jaraco-context': '5.3.0',
    E      'jaraco-functools': '4.0.1',
    E      'jaraco-text': '3.12.1',
    E      'more-itertools': '10.3.0',
    E      'ordered-set': '4.1.0',
    E      'platformdirs': '4.2.2',
    E      'tomli': '2.0.1',
    E      'typeguard': '4.3.0',
    E      'typing-extensions': '4.12.2',
    E      'wheel': '0.43.0',
    E      'zipp': '3.19.2'}
    E     Full diff:
    E       {
    E        'asttokens': '2.4.1',
    E        'attrs': '23.2.0',
    E     -  'autocommand': '2.2.2',
    E     -  'backports-tarfile': '1.2.0',
    E        'certifi': '2024.7.4',
    E        'charset-normalizer': '3.3.2',
    E        'colorama': '0.4.6',
    E        'coverage': '7.6.0',
    E        'docopt': '0.6.2',
    E        'executing': '2.0.1',
    E        'idna': '3.7',
    E     -  'importlib-metadata': '8.0.0',
    E     -  'importlib-resources': '6.4.0',
    E     -  'inflect': '7.3.1',
    E        'iniconfig': '2.0.0',
    E     -  'jaraco-context': '5.3.0',
    E     -  'jaraco-functools': '4.0.1',
    E     -  'jaraco-text': '3.12.1',
    E        'jsonschema': '4.23.0',
    E        'jsonschema-specifications': '2023.12.1',
    E        'markupsafe': '2.1.5',
    E     -  'more-itertools': '10.3.0',
    E     -  'ordered-set': '4.1.0',
    E        'packaging': '24.1',
    E        'pip': '24.0',
    E     -  'platformdirs': '4.2.2',
    E        'pluggy': '1.5.0',
    E        'py': '1.11.0',
    E        'pyrsistent': '0.20.0',
    E        'pysocks': '1.7.1',
    E        'pytest': '6.2.5',
    E        'pytest-asyncio': '0.20.3',
    E        'pytest-cov': '5.0.0',
    E        'pytest-forked': '1.6.0',
    E        'pytest-localserver': '0.8.1',
    E        'pytest-watch': '4.2.0',
    E        'pyyaml': '6.0.1',
    E        'referencing': '0.35.1',
    E        'requests': '2.32.3',
    E        'responses': '0.25.3',
    E        'rpds-py': '0.19.0',
    E        'sentry-sdk': '2.10.0',
    E        'setuptools': '71.0.2',
    E        'six': '1.16.0',
    E        'toml': '0.10.2',
    E     -  'tomli': '2.0.1',
    E     -  'typeguard': '4.3.0',
    E     -  'typing-extensions': '4.12.2',
    E        'urllib3': '2.2.2',
    E        'watchdog': '4.0.1',
    E        'werkzeug': '3.0.3',
    E     -  'wheel': '0.43.0',
    E     -  'zipp': '3.19.2',
    E       }
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.12.4.../x64/lib/python3.12/unittest/mock.py:955: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.12.4.../x64/lib/python3.12/unittest/mock.py:955: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.12-gevent

  • Class name: tests.test_utils
    Test name: test_installed_modules

    tests/test_utils.py:538: in test_installed_modules
        assert installed_distributions == importlib_distributions
    E   AssertionError: assert {'asttokens': '2.4.1',\n 'attrs': '23.2.0',\n 'certifi': '2024.7.4',\n 'charset-normalizer': '3.3.2',\n 'colorama': '0.4.6',\n 'coverage': '7.6.0',\n 'docopt': '0.6.2',\n 'executing': '2.0.1',\n 'gevent': '24.2.1',\n 'greenlet': '3.0.3',\n 'idna': '3.7',\n 'iniconfig': '2.0.0',\n 'jsonschema': '4.23.0',\n 'jsonschema-specifications': '2023.12.1',\n 'markupsafe': '2.1.5',\n 'packaging': '24.1',\n 'pip': '24.0',\n 'pluggy': '1.5.0',\n 'py': '1.11.0',\n 'pyrsistent': '0.20.0',\n 'pysocks': '1.7.1',\n 'pytest': '6.2.5',\n 'pytest-cov': '5.0.0',\n 'pytest-forked': '1.6.0',\n 'pytest-localserver': '0.8.1',\n 'pytest-watch': '4.2.0',\n 'pyyaml': '6.0.1',\n 'referencing': '0.35.1',\n 'requests': '2.32.3',\n 'responses': '0.25.3',\n 'rpds-py': '0.19.0',\n 'sentry-sdk': '2.10.0',\n 'setuptools': '71.0.2',\n 'six': '1.16.0',\n 'toml': '0.10.2',\n 'urllib3': '2.2.2',\n 'watchdog': '4.0.1',\n 'werkzeug': '3.0.3',\n 'zope-event': '5.0',\n 'zope-interface': '6.4.post2'} == {'asttokens': '2.4.1',\n 'attrs': '23.2.0',\n 'autocommand': '2.2.2',\n 'backports-tarfile': '1.2.0',\n 'certifi': '2024.7.4',\n 'charset-normalizer': '3.3.2',\n 'colorama': '0.4.6',\n 'coverage': '7.6.0',\n 'docopt': '0.6.2',\n 'executing': '2.0.1',\n 'gevent': '24.2.1',\n 'greenlet': '3.0.3',\n 'idna': '3.7',\n 'importlib-metadata': '8.0.0',\n 'importlib-resources': '6.4.0',\n 'inflect': '7.3.1',\n 'iniconfig': '2.0.0',\n 'jaraco-context': '5.3.0',\n 'jaraco-functools': '4.0.1',\n 'jaraco-text': '3.12.1',\n 'jsonschema': '4.23.0',\n 'jsonschema-specifications': '2023.12.1',\n 'markupsafe': '2.1.5',\n 'more-itertools': '10.3.0',\n 'ordered-set': '4.1.0',\n 'packaging': '24.1',\n 'pip': '24.0',\n 'platformdirs': '4.2.2',\n 'pluggy': '1.5.0',\n 'py': '1.11.0',\n 'pyrsistent': '0.20.0',\n 'pysocks': '1.7.1',\n 'pytest': '6.2.5',\n 'pytest-cov': '5.0.0',\n 'pytest-forked': '1.6.0',\n 'pytest-localserver': '0.8.1',\n 'pytest-watch': '4.2.0',\n 'pyyaml': '6.0.1',\n 'referencing': '0.35.1',\n 'requests': '2.32.3',\n 'responses': '0.25.3',\n 'rpds-py': '0.19.0',\n 'sentry-sdk': '2.10.0',\n 'setuptools': '71.0.2',\n 'six': '1.16.0',\n 'toml': '0.10.2',\n 'tomli': '2.0.1',\n 'typeguard': '4.3.0',\n 'typing-extensions': '4.12.2',\n 'urllib3': '2.2.2',\n 'watchdog': '4.0.1',\n 'werkzeug': '3.0.3',\n 'wheel': '0.43.0',\n 'zipp': '3.19.2',\n 'zope-event': '5.0',\n 'zope-interface': '6.4.post2'}
    E     Common items:
    E     {'asttokens': '2.4.1',
    E      'attrs': '23.2.0',
    E      'certifi': '2024.7.4',
    E      'charset-normalizer': '3.3.2',
    E      'colorama': '0.4.6',
    E      'coverage': '7.6.0',
    E      'docopt': '0.6.2',
    E      'executing': '2.0.1',
    E      'gevent': '24.2.1',
    E      'greenlet': '3.0.3',
    E      'idna': '3.7',
    E      'iniconfig': '2.0.0',
    E      'jsonschema': '4.23.0',
    E      'jsonschema-specifications': '2023.12.1',
    E      'markupsafe': '2.1.5',
    E      'packaging': '24.1',
    E      'pip': '24.0',
    E      'pluggy': '1.5.0',
    E      'py': '1.11.0',
    E      'pyrsistent': '0.20.0',
    E      'pysocks': '1.7.1',
    E      'pytest': '6.2.5',
    E      'pytest-cov': '5.0.0',
    E      'pytest-forked': '1.6.0',
    E      'pytest-localserver': '0.8.1',
    E      'pytest-watch': '4.2.0',
    E      'pyyaml': '6.0.1',
    E      'referencing': '0.35.1',
    E      'requests': '2.32.3',
    E      'responses': '0.25.3',
    E      'rpds-py': '0.19.0',
    E      'sentry-sdk': '2.10.0',
    E      'setuptools': '71.0.2',
    E      'six': '1.16.0',
    E      'toml': '0.10.2',
    E      'urllib3': '2.2.2',
    E      'watchdog': '4.0.1',
    E      'werkzeug': '3.0.3',
    E      'zope-event': '5.0',
    E      'zope-interface': '6.4.post2'}
    E     Right contains 16 more items:
    E     {'autocommand': '2.2.2',
    E      'backports-tarfile': '1.2.0',
    E      'importlib-metadata': '8.0.0',
    E      'importlib-resources': '6.4.0',
    E      'inflect': '7.3.1',
    E      'jaraco-context': '5.3.0',
    E      'jaraco-functools': '4.0.1',
    E      'jaraco-text': '3.12.1',
    E      'more-itertools': '10.3.0',
    E      'ordered-set': '4.1.0',
    E      'platformdirs': '4.2.2',
    E      'tomli': '2.0.1',
    E      'typeguard': '4.3.0',
    E      'typing-extensions': '4.12.2',
    E      'wheel': '0.43.0',
    E      'zipp': '3.19.2'}
    E     Full diff:
    E       {
    E        'asttokens': '2.4.1',
    E        'attrs': '23.2.0',
    E     -  'autocommand': '2.2.2',
    E     -  'backports-tarfile': '1.2.0',
    E        'certifi': '2024.7.4',
    E        'charset-normalizer': '3.3.2',
    E        'colorama': '0.4.6',
    E        'coverage': '7.6.0',
    E        'docopt': '0.6.2',
    E        'executing': '2.0.1',
    E        'gevent': '24.2.1',
    E        'greenlet': '3.0.3',
    E        'idna': '3.7',
    E     -  'importlib-metadata': '8.0.0',
    E     -  'importlib-resources': '6.4.0',
    E     -  'inflect': '7.3.1',
    E        'iniconfig': '2.0.0',
    E     -  'jaraco-context': '5.3.0',
    E     -  'jaraco-functools': '4.0.1',
    E     -  'jaraco-text': '3.12.1',
    E        'jsonschema': '4.23.0',
    E        'jsonschema-specifications': '2023.12.1',
    E        'markupsafe': '2.1.5',
    E     -  'more-itertools': '10.3.0',
    E     -  'ordered-set': '4.1.0',
    E        'packaging': '24.1',
    E        'pip': '24.0',
    E     -  'platformdirs': '4.2.2',
    E        'pluggy': '1.5.0',
    E        'py': '1.11.0',
    E        'pyrsistent': '0.20.0',
    E        'pysocks': '1.7.1',
    E        'pytest': '6.2.5',
    E        'pytest-cov': '5.0.0',
    E        'pytest-forked': '1.6.0',
    E        'pytest-localserver': '0.8.1',
    E        'pytest-watch': '4.2.0',
    E        'pyyaml': '6.0.1',
    E        'referencing': '0.35.1',
    E        'requests': '2.32.3',
    E        'responses': '0.25.3',
    E        'rpds-py': '0.19.0',
    E        'sentry-sdk': '2.10.0',
    E        'setuptools': '71.0.2',
    E        'six': '1.16.0',
    E        'toml': '0.10.2',
    E     -  'tomli': '2.0.1',
    E     -  'typeguard': '4.3.0',
    E     -  'typing-extensions': '4.12.2',
    E        'urllib3': '2.2.2',
    E        'watchdog': '4.0.1',
    E        'werkzeug': '3.0.3',
    E     -  'wheel': '0.43.0',
    E     -  'zipp': '3.19.2',
    E        'zope-event': '5.0',
    E        'zope-interface': '6.4.post2',
    E       }
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.12.4.../x64/lib/python3.12/unittest/mock.py:955: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.13-common

  • Class name: tests.test_utils
    Test name: test_installed_modules

    tests/test_utils.py:538: in test_installed_modules
        assert installed_distributions == importlib_distributions
    E   AssertionError: assert {'sentry-sdk': '2.10.0', 'rpds-py': '0.19.0', 'pysocks': '1.7.1', 'watchdog': '4.0.1', 'iniconfig': '2.0.0', 'pluggy': '1.5.0', 'executing': '2.0.1', 'idna': '3.7', 'referencing': '0.35.1', 'responses': '0.25.3', 'jsonschema': '4.23.0', 'py': '1.11.0', 'colorama': '0.4.6', 'certifi': '2024.7.4', 'packaging': '24.1', 'pytest-asyncio': '0.23.8', 'werkzeug': '3.0.3', 'pytest-localserver': '0.8.1', 'pyrsistent': '0.20.0', 'pytest-forked': '1.6.0', 'six': '1.16.0', 'markupsafe': '2.1.5', 'pytest': '8.2.2', 'pytest-cov': '5.0.0', 'charset-normalizer': '3.3.2', 'asttokens': '2.4.1', 'docopt': '0.6.2', 'coverage': '7.6.0', 'requests': '2.32.3', 'pip': '24.0', 'jsonschema-specifications': '2023.12.1', 'pyyaml': '6.0.1', 'urllib3': '2.2.2', 'setuptools': '71.0.2', 'pytest-watch': '4.2.0', 'attrs': '23.2.0'} == {'sentry-sdk': '2.10.0', 'rpds-py': '0.19.0', 'pysocks': '1.7.1', 'watchdog': '4.0.1', 'iniconfig': '2.0.0', 'pluggy': '1.5.0', 'executing': '2.0.1', 'idna': '3.7', 'referencing': '0.35.1', 'responses': '0.25.3', 'jsonschema': '4.23.0', 'py': '1.11.0', 'colorama': '0.4.6', 'certifi': '2024.7.4', 'packaging': '24.1', 'pytest-asyncio': '0.23.8', 'werkzeug': '3.0.3', 'pytest-localserver': '0.8.1', 'pyrsistent': '0.20.0', 'pytest-forked': '1.6.0', 'six': '1.16.0', 'markupsafe': '2.1.5', 'pytest': '8.2.2', 'pytest-cov': '5.0.0', 'charset-normalizer': '3.3.2', 'asttokens': '2.4.1', 'docopt': '0.6.2', 'coverage': '7.6.0', 'requests': '2.32.3', 'pip': '24.0', 'jsonschema-specifications': '2023.12.1', 'pyyaml': '6.0.1', 'urllib3': '2.2.2', 'setuptools': '71.0.2', 'pytest-watch': '4.2.0', 'attrs': '23.2.0', 'jaraco-context': '5.3.0', 'jaraco-functools': '4.0.1', 'typing-extensions': '4.12.2', 'backports-tarfile': '1.2.0', 'tomli': '2.0.1', 'inflect': '7.3.1', 'jaraco-text': '3.12.1', 'importlib-resources': '6.4.0', 'importlib-metadata': '8.0.0', 'more-itertools': '10.3.0', 'typeguard': '4.3.0', 'autocommand': '2.2.2', 'platformdirs': '4.2.2', 'ordered-set': '4.1.0', 'zipp': '3.19.2', 'wheel': '0.43.0'}
    E     
    E     Common items:
    E     {'asttokens': '2.4.1',
    E      'attrs': '23.2.0',
    E      'certifi': '2024.7.4',
    E      'charset-normalizer': '3.3.2',
    E      'colorama': '0.4.6',
    E      'coverage': '7.6.0',
    E      'docopt': '0.6.2',
    E      'executing': '2.0.1',
    E      'idna': '3.7',
    E      'iniconfig': '2.0.0',
    E      'jsonschema': '4.23.0',
    E      'jsonschema-specifications': '2023.12.1',
    E      'markupsafe': '2.1.5',
    E      'packaging': '24.1',
    E      'pip': '24.0',
    E      'pluggy': '1.5.0',
    E      'py': '1.11.0',
    E      'pyrsistent': '0.20.0',
    E      'pysocks': '1.7.1',
    E      'pytest': '8.2.2',
    E      'pytest-asyncio': '0.23.8',
    E      'pytest-cov': '5.0.0',
    E      'pytest-forked': '1.6.0',
    E      'pytest-localserver': '0.8.1',
    E      'pytest-watch': '4.2.0',
    E      'pyyaml': '6.0.1',
    E      'referencing': '0.35.1',
    E      'requests': '2.32.3',
    E      'responses': '0.25.3',
    E      'rpds-py': '0.19.0',
    E      'sentry-sdk': '2.10.0',
    E      'setuptools': '71.0.2',
    E      'six': '1.16.0',
    E      'urllib3': '2.2.2',
    E      'watchdog': '4.0.1',
    E      'werkzeug': '3.0.3'}
    E     Right contains 16 more items:
    E     {'autocommand': '2.2.2',
    E      'backports-tarfile': '1.2.0',
    E      'importlib-metadata': '8.0.0',
    E      'importlib-resources': '6.4.0',
    E      'inflect': '7.3.1',
    E      'jaraco-context': '5.3.0',
    E      'jaraco-functools': '4.0.1',
    E      'jaraco-text': '3.12.1',
    E      'more-itertools': '10.3.0',
    E      'ordered-set': '4.1.0',
    E      'platformdirs': '4.2.2',
    E      'tomli': '2.0.1',
    E      'typeguard': '4.3.0',
    E      'typing-extensions': '4.12.2',
    E      'wheel': '0.43.0',
    E      'zipp': '3.19.2'}
    E     
    E     Full diff:
    E       {
    E           'asttokens': '2.4.1',
    E           'attrs': '23.2.0',
    E     -     'autocommand': '2.2.2',
    E     -     'backports-tarfile': '1.2.0',
    E           'certifi': '2024.7.4',
    E           'charset-normalizer': '3.3.2',
    E           'colorama': '0.4.6',
    E           'coverage': '7.6.0',
    E           'docopt': '0.6.2',
    E           'executing': '2.0.1',
    E           'idna': '3.7',
    E     -     'importlib-metadata': '8.0.0',
    E     -     'importlib-resources': '6.4.0',
    E     -     'inflect': '7.3.1',
    E           'iniconfig': '2.0.0',
    E     -     'jaraco-context': '5.3.0',
    E     -     'jaraco-functools': '4.0.1',
    E     -     'jaraco-text': '3.12.1',
    E           'jsonschema': '4.23.0',
    E           'jsonschema-specifications': '2023.12.1',
    E           'markupsafe': '2.1.5',
    E     -     'more-itertools': '10.3.0',
    E     -     'ordered-set': '4.1.0',
    E           'packaging': '24.1',
    E           'pip': '24.0',
    E     -     'platformdirs': '4.2.2',
    E           'pluggy': '1.5.0',
    E           'py': '1.11.0',
    E           'pyrsistent': '0.20.0',
    E           'pysocks': '1.7.1',
    E           'pytest': '8.2.2',
    E           'pytest-asyncio': '0.23.8',
    E           'pytest-cov': '5.0.0',
    E           'pytest-forked': '1.6.0',
    E           'pytest-localserver': '0.8.1',
    E           'pytest-watch': '4.2.0',
    E           'pyyaml': '6.0.1',
    E           'referencing': '0.35.1',
    E           'requests': '2.32.3',
    E           'responses': '0.25.3',
    E           'rpds-py': '0.19.0',
    E           'sentry-sdk': '2.10.0',
    E           'setuptools': '71.0.2',
    E           'six': '1.16.0',
    E     -     'tomli': '2.0.1',
    E     -     'typeguard': '4.3.0',
    E     -     'typing-extensions': '4.12.2',
    E           'urllib3': '2.2.2',
    E           'watchdog': '4.0.1',
    E           'werkzeug': '3.0.3',
    E     -     'wheel': '0.43.0',
    E     -     'zipp': '3.19.2',
    E       }
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.13.0-beta..../x64/lib/python3.13/unittest/mock.py:988: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.13.0-beta..../x64/lib/python3.13/unittest/mock.py:988: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.6-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:78: in test_trace_decorator_async_no_trx
        "test_decorator.my_async_example_function",
    .../hostedtoolcache/Python/3.6.15.../x64/lib/python3.6/unittest/mock.py:824: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:45: in test_trace_decorator_no_trx
        "test_decorator.my_example_function",
    .../hostedtoolcache/Python/3.6.15.../x64/lib/python3.6/unittest/mock.py:824: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.6-gevent

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:45: in test_trace_decorator_no_trx
        "test_decorator.my_example_function",
    .../hostedtoolcache/Python/3.6.15.../x64/lib/python3.6/unittest/mock.py:824: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.7-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:78: in test_trace_decorator_async_no_trx
        "test_decorator.my_async_example_function",
    .../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/unittest/mock.py:888: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:45: in test_trace_decorator_no_trx
        "test_decorator.my_example_function",
    .../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/unittest/mock.py:888: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.8-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.8.18.../x64/lib/python3.8/unittest/mock.py:924: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.8.18.../x64/lib/python3.8/unittest/mock.py:924: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.8-gevent

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.8.18.../x64/lib/python3.8/unittest/mock.py:924: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

py3.9-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_async_no_trx

    tests/tracing/test_decorator.py:75: in test_trace_decorator_async_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.9.19.../x64/lib/python3.9/unittest/mock.py:918: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.
  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
        fake_warning.assert_called_once_with(
    .../hostedtoolcache/Python/3.9.19.../x64/lib/python3.9/unittest/mock.py:918: in assert_called_once_with
        raise AssertionError(msg)
    E   AssertionError: Expected 'mock' to be called once. Called 0 times.

antonpirker
antonpirker approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sentrivana sentrivana marked this pull request as ready for review July 22, 2024 13:33
@sentrivana sentrivana merged commit 25de71e into master Jul 22, 2024
123 checks passed
@sentrivana sentrivana deleted the ivana/warning-to-debug branch July 22, 2024 13:34
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
@sentrivana @antonpirker @arjenzorgdoc
ref(logging): Lower logger level for some messages (getsentry#3305)
000d718 
These messages might blow up in volume. This might end up clogging up users' logs. Let's only emit them if debug mode is on.

---------

Co-authored-by: Anton Pirker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @antonpirker