Skip to content

Fix flaky transport test #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Fix flaky transport test #3666

merged 5 commits into from
Oct 17, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 17, 2024

The test_transport_works test is flaking ~7 our of 10 times after adding brotli, but only on 3.6 with gevent and only in CI.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (9ae5820) to head (3707aaf).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
- Coverage   84.32%   84.30%   -0.02%     
==========================================
  Files         133      133              
  Lines       14226    14227       +1     
  Branches     2398     2398              
==========================================
- Hits        11996    11994       -2     
- Misses       1487     1489       +2     
- Partials      743      744       +1     
Files with missing lines Coverage Δ
sentry_sdk/_compat.py 94.87% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review October 17, 2024 07:53
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Python 3.6 and brotli is probably a combination that is not that common (according to my gut feeling)

@sentrivana sentrivana enabled auto-merge (squash) October 17, 2024 08:08
@sentrivana sentrivana merged commit 365d9cf into master Oct 17, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/fix-transport-test branch October 17, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants