Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags): fix/refactor flaky launchdarkly tests #3896

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Dec 26, 2024

Fixes flakes (example) caused by background processes in LDClient trying to connect to a non-existent server (we're mocking the flag data through TestData).

Copy link

codecov bot commented Dec 26, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13832 1 13831 4140
View the top 1 failed tests by shortest run time
tests.test_transport test_transport_works[threads-False-gzip-0-True-flush-False]
Stack Traces | 2.52s run time
tests/test_transport.py:187: in test_transport_works
    assert capturing_server.captured
E   AssertionError: assert []
E    +  where [] = <CapturingServer(<class 'tests.test_transport.CapturingServer'>, started 140302203479808)>.captured

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@aliu39
Copy link
Member Author

aliu39 commented Dec 27, 2024

Looks like anthropic-pinned is failing now for 3.7 and 3.8: https://github.com/getsentry/sentry-python/actions/runs/12508778454/job/34899363812?pr=3896

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antonpirker
Copy link
Member

The anthropic tests are flaky, so we will deal with them in another PR.

@antonpirker antonpirker merged commit fd22494 into master Jan 7, 2025
137 checks passed
@antonpirker antonpirker deleted the aliu/fix-ld-test branch January 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants