Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(baggage): Document that caller must check mutable #4010

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

szokeasaurusrex
Copy link
Member

The Baggage class does not enforce mutability. Document this to avoid confusion.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

The `Baggage` class does not enforce mutability. Document this to avoid confusion.
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) January 31, 2025 10:38
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (5771f3e) to head (cbf2275).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4010      +/-   ##
==========================================
- Coverage   79.58%   79.56%   -0.02%     
==========================================
  Files         141      141              
  Lines       15711    15711              
  Branches     2671     2671              
==========================================
- Hits        12504    12501       -3     
  Misses       2367     2367              
- Partials      840      843       +3     
Files with missing lines Coverage Δ
sentry_sdk/tracing_utils.py 85.50% <ø> (ø)

... and 3 files with indirect coverage changes

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
@szokeasaurusrex szokeasaurusrex merged commit 7a38347 into master Mar 17, 2025
140 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/doc-baggage-mutable branch March 17, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants