Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(httplib): Fix flakey https test #4057

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Ideally this test shouldn't even make a request anywhere but this should make it
a little more stable.
@Zylphrex Zylphrex requested a review from sentrivana February 14, 2025 21:50
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (ae68d85) to head (b601c9e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
+ Coverage   79.55%   79.56%   +0.01%     
==========================================
  Files         140      140              
  Lines       15508    15508              
  Branches     2628     2628              
==========================================
+ Hits        12337    12339       +2     
  Misses       2335     2335              
+ Partials      836      834       -2     

see 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zylphrex!

@sentrivana sentrivana merged commit 6a1b7d4 into master Feb 17, 2025
142 checks passed
@sentrivana sentrivana deleted the txiao/tests/fix-flakey-https-test branch February 17, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants