Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): reverse profile_session start/stop methods deprecation #4162

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Mar 19, 2025

Revert back to using start_profiler and stop_profiler function names and deprecate the *_session ones instead.

Prior PR that introduced the change we're undoing: #4056

@viglia viglia requested review from indragiek and JonasBa March 19, 2025 07:26
@viglia viglia self-assigned this Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (bc54a1d) to head (5807ca6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/profiler/continuous_profiler.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4162      +/-   ##
==========================================
- Coverage   79.57%   79.52%   -0.06%     
==========================================
  Files         141      141              
  Lines       15714    15714              
  Branches     2671     2671              
==========================================
- Hits        12505    12497       -8     
- Misses       2367     2376       +9     
+ Partials      842      841       -1     
Files with missing lines Coverage Δ
sentry_sdk/profiler/__init__.py 100.00% <ø> (ø)
sentry_sdk/profiler/continuous_profiler.py 85.57% <75.00%> (ø)

... and 4 files with indirect coverage changes

@viglia viglia requested review from a team and sentrivana March 19, 2025 08:09
@viglia viglia merged commit f6db981 into master Mar 19, 2025
139 of 140 checks passed
@viglia viglia deleted the viglia/ref/reverse-start-profile-deprecation branch March 19, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants