-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed flaky test #4165
Fixed flaky test #4165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4165 +/- ##
==========================================
+ Coverage 79.49% 79.57% +0.07%
==========================================
Files 141 141
Lines 15732 15732
Branches 2675 2675
==========================================
+ Hits 12506 12518 +12
+ Misses 2379 2368 -11
+ Partials 847 846 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't a more robust solution be to use a mock server? I feel like tests in general should not be depending on a real network connection, as it introduces to many opportunities for flakiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
The URL www.squirrelchasers.com is actually existing, so we should not access it in our tests. Hope this make the test more stable.