Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations/dramatiq): use set_transaction_name #4175

Merged

Conversation

timdrijvers
Copy link
Contributor

@timdrijvers timdrijvers commented Mar 20, 2025

The Dramatiq integration is using a deprecated method to set the scope's transaction name, use set_transaction_name instead.

"Assigning to scope.transaction directly is deprecated: use scope.set_transaction_name() instead."

The Dramatiq integration is using a deprecated method to set the scope's
transaction name, use set_transaction_name instead.

"Assigning to scope.transaction directly is deprecated: use
scope.set_transaction_name() instead."
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @timdrijvers!

@sentrivana sentrivana enabled auto-merge (squash) March 25, 2025 13:20
@sentrivana sentrivana requested a review from a team as a code owner March 25, 2025 13:20
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (08bbe00) to head (c35e622).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
+ Coverage   79.57%   79.58%   +0.01%     
==========================================
  Files         141      141              
  Lines       15737    15737              
  Branches     2675     2675              
==========================================
+ Hits        12522    12525       +3     
+ Misses       2369     2367       -2     
+ Partials      846      845       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/dramatiq.py 80.72% <100.00%> (ø)

... and 3 files with indirect coverage changes

@sentrivana sentrivana merged commit 984f29a into getsentry:master Mar 25, 2025
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants