-
Notifications
You must be signed in to change notification settings - Fork 535
ci: Move mypy
config into pyproject.toml
#4181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Move mypy
config into pyproject.toml
#4181
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4181 +/- ##
==========================================
- Coverage 79.58% 79.56% -0.02%
==========================================
Files 141 141
Lines 15736 15736
Branches 2675 2675
==========================================
- Hits 12524 12521 -3
- Misses 2367 2369 +2
- Partials 845 846 +1 |
mypy
config into pyproject.toml
mypy
config into pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments before merge. Also, if there is an issue associated with this PR, might help to link them for context (I was kinda missing context when reviewing this)
disallow_untyped_defs = true | ||
no_implicit_optional = true | ||
python_version = "3.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR, but perhaps we should bump this?
Co-authored-by: Daniel Szoke <[email protected]>
First step to consolidate configuration into
pyproject.toml
.