-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ubuntu in Github test runners #4204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4204 +/- ##
=======================================
Coverage 79.50% 79.50%
=======================================
Files 141 141
Lines 15800 15800
Branches 2700 2700
=======================================
Hits 12561 12561
Misses 2378 2378
Partials 861 861 |
701c59d
to
b073869
Compare
1ded389
to
2146012
Compare
…y/sentry-python into antonpirker/update-ubuntu-in-ci
@@ -52,6 +53,7 @@ def inner(propagate_traces=True, monitor_beat_tasks=False, **kwargs): | |||
return inner | |||
|
|||
|
|||
@pytest.mark.skipif(sys.version_info < (3, 7), reason="Requires Python 3.7+") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those integration tests (that are more for documentation) are hanging in Python 3.6 when using the Python Docker container. I just deactivated them, because we will remove 3.6 support soon anyhow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! One question though: why are we only using ubuntu-22.04
, rather than the more recent ubuntu-24.04
?
Also, just for my understanding, what is the purpose of the Docker container for Python 3.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! <3
Echoing Daniel's comment about a newer Ubuntu version -- do we need 22.04 specifically or can we go higher?
I tried to upgrade to 24.04 but then we need to use Docker for Python 3.6 and 3.7 (we need docker because Ubuntu does not have the old python installation packages anymore.) |
The runner
ubuntu-20.04
will be removed on April 1st, 2025.