Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu in Github test runners #4204

Merged
merged 32 commits into from
Mar 28, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Mar 27, 2025

The runner ubuntu-20.04 will be removed on April 1st, 2025.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (3d2f044) to head (a4a01fb).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4204   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files         141      141           
  Lines       15800    15800           
  Branches     2700     2700           
=======================================
  Hits        12561    12561           
  Misses       2378     2378           
  Partials      861      861           

@antonpirker antonpirker force-pushed the antonpirker/update-ubuntu-in-ci branch from 701c59d to b073869 Compare March 27, 2025 12:49
@antonpirker antonpirker force-pushed the antonpirker/update-ubuntu-in-ci branch from 1ded389 to 2146012 Compare March 27, 2025 15:07
@@ -52,6 +53,7 @@ def inner(propagate_traces=True, monitor_beat_tasks=False, **kwargs):
return inner


@pytest.mark.skipif(sys.version_info < (3, 7), reason="Requires Python 3.7+")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those integration tests (that are more for documentation) are hanging in Python 3.6 when using the Python Docker container. I just deactivated them, because we will remove 3.6 support soon anyhow.

@antonpirker antonpirker marked this pull request as ready for review March 28, 2025 09:52
@antonpirker antonpirker requested a review from a team as a code owner March 28, 2025 09:52
@antonpirker antonpirker requested a review from sentrivana March 28, 2025 09:52
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! One question though: why are we only using ubuntu-22.04, rather than the more recent ubuntu-24.04?

Also, just for my understanding, what is the purpose of the Docker container for Python 3.6?

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! <3

Echoing Daniel's comment about a newer Ubuntu version -- do we need 22.04 specifically or can we go higher?

@antonpirker
Copy link
Member Author

I tried to upgrade to 24.04 but then we need to use Docker for Python 3.6 and 3.7 (we need docker because Ubuntu does not have the old python installation packages anymore.)
And when switching to 24.04 some other things broke, and after an hour or two trying to fix this I just reverted and made 22.04 work.

@antonpirker antonpirker merged commit 4aaadf4 into master Mar 28, 2025
139 checks passed
@antonpirker antonpirker deleted the antonpirker/update-ubuntu-in-ci branch March 28, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants