Skip to content

feat: Sample everything 100% w/ Spotlight & no DSN set #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

feat: Sample everything 100% w/ Spotlight & no DSN set #4207

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4dec89
feat: Sample everything 100% w/ Spotlight & no DSN set
BYK Mar 27, 2025
da1888d
fix test/type issues
BYK Mar 27, 2025
cde3cfc
Add *kwargs too, just in case
BYK Mar 28, 2025
4e2f6b3
Merge branch 'master' into byk/feat/enable-all-sampling-with-spotlight
BYK Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,12 @@ def _capture_envelope(envelope):

if self.options.get("spotlight"):
self.spotlight = setup_spotlight(self.options)
if not self.options["dsn"]:
sample_all = lambda *_args, **_kwargs: 1.0
self.options["send_default_pii"] = True
self.options["error_sampler"] = sample_all
self.options["traces_sampler"] = sample_all
self.options["profiles_sampler"] = sample_all

sdk_name = get_sdk_name(list(self.integrations.keys()))
SDK_INFO["name"] = sdk_name
Expand Down Expand Up @@ -468,11 +474,7 @@ def should_send_default_pii(self):

Returns whether the client should send default PII (Personally Identifiable Information) data to Sentry.
"""
result = self.options.get("send_default_pii")
if result is None:
result = not self.options["dsn"] and self.spotlight is not None

return result
return self.options.get("send_default_pii") or False

@property
def dsn(self):
Expand Down
Loading