Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix GraphQL failures #4208

Merged
merged 4 commits into from
Mar 28, 2025
Merged

ci: Fix GraphQL failures #4208

merged 4 commits into from
Mar 28, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 28, 2025

Looks like strawberry is not compatible with the latest pydantic release (2.11.0). Restrict the version of pydantic used in strawberry tests for now.

sqlalchemy apparently released a new version which made it in by rerunning toxgen.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (e432fb4) to head (bedbb98).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4208      +/-   ##
==========================================
+ Coverage   79.53%   79.56%   +0.03%     
==========================================
  Files         141      141              
  Lines       15800    15800              
  Branches     2700     2700              
==========================================
+ Hits        12566    12572       +6     
+ Misses       2376     2369       -7     
- Partials      858      859       +1     

see 3 files with indirect coverage changes

@sentrivana sentrivana changed the title Test CI ci: Fix GraphQL failures Mar 28, 2025
@sentrivana sentrivana marked this pull request as ready for review March 28, 2025 09:01
@sentrivana sentrivana requested a review from a team as a code owner March 28, 2025 09:01
@szokeasaurusrex
Copy link
Member

should we maybe try to pin pydantic more broadly in our tests to prevent such issues from arising in the future?

@sentrivana sentrivana enabled auto-merge (squash) March 28, 2025 09:03
@sentrivana sentrivana merged commit 3d2f044 into master Mar 28, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/test-ci-4 branch March 28, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants