Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not spam sentry_sdk.warnings logger w/ Spotlight #4219

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Mar 31, 2025

Sometimes one may have Spotlight turned on in the SDK but not have the sidecar running or reachable. In that case we spam the console with every event as they fail to reach Spotlight. This patch limits the fail warnings to 3: the first 2 are actual errors and the final one is a note about shutting up.

Sometimes one may have Spotlight turned on in the SDK but not have the sidecar running or reachable. In that case we spam the console with every event as they fail to reach Spotlight. This patch limits the fail warnings to 3: the first 2 are actual errors and the final one is a note about shutting up.
@BYK BYK requested a review from a team as a code owner March 31, 2025 15:20
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.48%. Comparing base (3b28649) to head (2c957c3).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/spotlight.py 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
- Coverage   79.51%   79.48%   -0.04%     
==========================================
  Files         141      141              
  Lines       15803    15809       +6     
  Branches     2701     2703       +2     
==========================================
  Hits        12565    12565              
- Misses       2378     2382       +4     
- Partials      860      862       +2     
Files with missing lines Coverage Δ
sentry_sdk/spotlight.py 54.70% <37.50%> (-2.06%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BYK BYK merged commit d0d70a5 into master Apr 1, 2025
138 of 139 checks passed
@BYK BYK deleted the byk/feat/no-spammy-spotlight branch April 1, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants