-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ourlogs): Add a class which batches groups of logs together. #4229
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4229 +/- ##
==========================================
- Coverage 79.49% 79.48% -0.02%
==========================================
Files 141 142 +1
Lines 15808 15886 +78
Branches 2702 2716 +14
==========================================
+ Hits 12567 12627 +60
- Misses 2380 2394 +14
- Partials 861 865 +4
|
0b2d8bf
to
7564711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing this PR locally, and some discussion outside of Github with Colin, and also because of the fact it is heavily based on the MetricsAggregator this is good to be merged.
8a482c4
to
1a029e3
Compare
Currently, sentry logs create a new envelope per-log, which is inefficient.
This changes the behavior to batch a large chunk of logs to be sent all at once.
Fixes #4155
Fixes #4225
Fixes #4152